Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/bots/compiler.py

Issue 226243002: Run language tests on ie11, too to ensure it's not the test framework problem. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
diff --git a/tools/bots/compiler.py b/tools/bots/compiler.py
index ec1051f4698bdf006fbf7e82794b4ba7df2a4f11..6b23de065241a6663fd3e7f52e8ef3458733dfeb 100644
--- a/tools/bots/compiler.py
+++ b/tools/bots/compiler.py
@@ -136,7 +136,7 @@ def GetBuildInfo(builder_name, is_buildbot):
def NeedsXterm(compiler, runtime):
- return runtime in ['ie9', 'ie10', 'ie11', 'chrome', 'safari', 'opera',
+ return runtime in ['ie9', 'ie10', 'ie11', 'chrome', 'safari', 'opera',
'ff', 'drt', 'dartium']
@@ -262,9 +262,13 @@ def TestCompiler(runtime, mode, system, flags, is_buildbot, arch,
TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'],
unit_test_flags, arch)
- if compiler == 'dart2js' and runtime in ['ie10', 'ie11']:
+ if compiler == 'dart2js' and runtime in ['ie10']:
TestStep(compiler, mode, system, compiler, runtime,
['html', 'pkg', 'samples'], flags, arch)
+ elif compiler == 'dart2js' and runtime in ['ie11']:
+ #TODO(efortuna): Remove this branch.
+ TestStep(compiler, mode, system, compiler, runtime,
+ ['html', 'pkg', 'samples', 'language'], flags, arch)
else:
# Run the default set of test suites.
TestStep(compiler, mode, system, compiler,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698