Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/offline_pages/background/request_queue.h

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.h
diff --git a/components/offline_pages/background/request_queue.h b/components/offline_pages/background/request_queue.h
index 5477c7ce0402e9eb20bac1d2ebfc532f33f8a74f..1e1764b0ebf9aaf01e1f31f8fb4f5c9d9bb28b26 100644
--- a/components/offline_pages/background/request_queue.h
+++ b/components/offline_pages/background/request_queue.h
@@ -50,7 +50,7 @@ class RequestQueue {
// Callback used for |GetRequests|.
typedef base::Callback<void(GetRequestsResult,
- const std::vector<SavePageRequest>&)>
+ std::vector<std::unique_ptr<SavePageRequest>>)>
GetRequestsCallback;
// Callback used for |AddRequest|.
@@ -61,13 +61,15 @@ class RequestQueue {
typedef base::Callback<void(UpdateRequestResult)> UpdateRequestCallback;
// Callback used by |ChangeState| for more than one update at a time.
- typedef base::Callback<void(const UpdateMultipleRequestResults& results,
- const std::vector<SavePageRequest>& requests)>
+ typedef base::Callback<void(
+ const UpdateMultipleRequestResults& results,
+ std::vector<std::unique_ptr<SavePageRequest>> requests)>
UpdateMultipleRequestsCallback;
// Callback used by |RemoveRequests|.
- typedef base::Callback<void(const UpdateMultipleRequestResults& results,
- const std::vector<SavePageRequest>& requests)>
+ typedef base::Callback<void(
+ const UpdateMultipleRequestResults& results,
+ std::vector<std::unique_ptr<SavePageRequest>> requests)>
RemoveRequestsCallback;
explicit RequestQueue(std::unique_ptr<RequestQueueStore> store);
@@ -108,7 +110,7 @@ class RequestQueue {
const RequestQueue::UpdateRequestCallback& update_callback,
const SavePageRequest& update_request,
bool success,
- const std::vector<SavePageRequest>& requests);
+ std::vector<std::unique_ptr<SavePageRequest>> requests);
private:
// Callback used by |PurgeRequests|.

Powered by Google App Engine
This is Rietveld 408576698