Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1911)

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
index 2eccc00eafe76f6ab211c64c2fbbb1c30dc6d861..eae4b94b19dc8ad51fc22db37b133c7f1cb9c045 100644
--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
@@ -118,20 +118,21 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(
void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(
std::string callback_id,
offline_pages::RequestQueue::GetRequestsResult result,
- const std::vector<offline_pages::SavePageRequest>& requests) {
+ std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests) {
base::ListValue save_page_requests;
if (result == offline_pages::RequestQueue::GetRequestsResult::SUCCESS) {
for (const auto& request : requests) {
base::DictionaryValue* save_page_request = new base::DictionaryValue();
save_page_requests.Append(save_page_request);
- save_page_request->SetString("onlineUrl", request.url().spec());
+ save_page_request->SetString("onlineUrl", request->url().spec());
save_page_request->SetDouble("creationTime",
- request.creation_time().ToJsTime());
+ request->creation_time().ToJsTime());
save_page_request->SetString("status", GetStringFromSavePageStatus());
- save_page_request->SetString("namespace", request.client_id().name_space);
+ save_page_request->SetString("namespace",
+ request->client_id().name_space);
save_page_request->SetDouble("lastAttempt",
- request.last_attempt_time().ToJsTime());
- save_page_request->SetString("id", std::to_string(request.request_id()));
+ request->last_attempt_time().ToJsTime());
+ save_page_request->SetString("id", std::to_string(request->request_id()));
}
}
ResolveJavascriptCallback(base::StringValue(callback_id), save_page_requests);

Powered by Google App Engine
This is Rietveld 408576698