components/offline_pages/background/request_queue_store.h - Issue 2262423002: Use a vector of smart pointers for callback return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback per BauerB Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/request_picker.cc ('K') | « components/offline_pages/background/request_queue_in_memory_store.cc ('k') | components/offline_pages/background/request_queue_store_sql.cc » ('j') | components/offline_pages/background/request_queue_store_sql.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_store.h

diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h

index 9622efd2206c11b457b51385c2b70356c8dba2a5..5c6deee02c5fdb3a3e48214d82a51ede8d542b2c 100644

--- a/components/offline_pages/background/request_queue_store.h

+++ b/components/offline_pages/background/request_queue_store.h

@@ -26,18 +26,18 @@ class RequestQueueStore {

typedef base::Callback<void(

bool /* success */,

- const std::vector<SavePageRequest>& /* requests */)>

+ std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>

GetRequestsCallback;

typedef base::Callback<void(UpdateStatus)> UpdateCallback;

// TODO(petewil) - UpdateMultiple looks exactly like Remove, consider

// merging them into a single callback.

typedef base::Callback<void(

const RequestQueue::UpdateMultipleRequestResults& /* statuses*/,

- const std::vector<SavePageRequest>& /* requests */)>

+ std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>

UpdateMultipleRequestsCallback;

typedef base::Callback<void(

const RequestQueue::UpdateMultipleRequestResults& /* statuses */,

- const std::vector<SavePageRequest>& /* requests */)>

+ std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>

RemoveCallback;

typedef base::Callback<void(bool /* success */)> ResetCallback;