Use a vector of smart pointers for callback return type.

chrome/browser/android/offline_pages/offline_page_bridge.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_bridge.h"
 
 #include <memory>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 120 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_result;
 
   if (result)
     j_result = ToJavaOfflinePageItem(env, *result);
   base::android::RunCallbackAndroid(j_callback_obj, j_result);
 }
 
 ScopedJavaLocalRef<jobjectArray> CreateJavaSavePageRequests(
     JNIEnv* env,
-    const std::vector<SavePageRequest>& requests) {
+    std::vector<std::unique_ptr<SavePageRequest>> requests) {
   ScopedJavaLocalRef<jclass> save_page_request_clazz = base::android::GetClass(
       env, "org/chromium/chrome/browser/offlinepages/SavePageRequest");
   jobjectArray joa = env->NewObjectArray(
       requests.size(), save_page_request_clazz.obj(), nullptr);
   base::android::CheckException(env);
 
   for (size_t i = 0; i < requests.size(); ++i) {
-    SavePageRequest request = requests[i];
+    SavePageRequest request = *(requests[i]);
     ScopedJavaLocalRef<jstring> name_space =
         ConvertUTF8ToJavaString(env, request.client_id().name_space);
     ScopedJavaLocalRef<jstring> id =
         ConvertUTF8ToJavaString(env, request.client_id().id);
     ScopedJavaLocalRef<jstring> url =
         ConvertUTF8ToJavaString(env, request.url().spec());
 
     ScopedJavaLocalRef<jobject> j_save_page_request =
         Java_SavePageRequest_create(env, (int)request.request_state(),
                                     request.request_id(), url, name_space, id);
     env->SetObjectArrayElement(joa, i, j_save_page_request.obj());
   }
 
   return ScopedJavaLocalRef<jobjectArray>(env, joa);
 }
 
-void OnGetAllRequestsDone(const ScopedJavaGlobalRef<jobject>& j_callback_obj,
-                          const std::vector<SavePageRequest>& all_requests) {
+void OnGetAllRequestsDone(
+    const ScopedJavaGlobalRef<jobject>& j_callback_obj,
+    std::vector<std::unique_ptr<SavePageRequest>> all_requests) {
   JNIEnv* env = base::android::AttachCurrentThread();
 
   ScopedJavaLocalRef<jobjectArray> j_result_obj =
-      CreateJavaSavePageRequests(env, all_requests);
+      CreateJavaSavePageRequests(env, std::move(all_requests));
   base::android::RunCallbackAndroid(j_callback_obj, j_result_obj);
 }
 
 void OnRemoveRequestsDone(
     const ScopedJavaGlobalRef<jobject>& j_callback_obj,
     const RequestQueue::UpdateMultipleRequestResults& removed_request_results) {
   JNIEnv* env = base::android::AttachCurrentThread();
 
   std::vector<int> update_request_results;
   std::vector<int64_t> update_request_ids;
@@ skipping 352 matching lines @@
       env, ConvertUTF8ToJavaString(env, client_id.name_space),
       ConvertUTF8ToJavaString(env, client_id.id));
 }
 
 bool RegisterOfflinePageBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace offline_pages