Use a vector of smart pointers for callback return type.

chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h"
 
 #include <vector>
 
 #include "base/android/jni_string.h"
 #include "base/bind.h"
@@ skipping 51 matching lines @@
     const DownloadUIItem& item) {
   return Java_OfflinePageDownloadBridge_createDownloadItem(
       env, ConvertUTF8ToJavaString(env, item.guid),
       ConvertUTF8ToJavaString(env, item.url.spec()),
       ConvertUTF16ToJavaString(env, item.title),
       ConvertUTF8ToJavaString(env, item.target_path.value()),
       item.start_time.ToJavaTime(), item.total_bytes);
 }
 
 std::vector<int64_t> FilterRequestsByGuid(
-    const std::vector<SavePageRequest>& requests,
+    std::vector<std::unique_ptr<SavePageRequest>> requests,
     const std::string& guid) {
   std::vector<int64_t> request_ids;
-  for (const SavePageRequest& request : requests) {
-    if (request.client_id().id == guid &&
-        (request.client_id().name_space == kDownloadNamespace ||
-         request.client_id().name_space == kAsyncNamespace)) {
-      request_ids.push_back(request.request_id());
+  for (const auto& request : requests) {
+    if (request->client_id().id == guid &&
+        (request->client_id().name_space == kDownloadNamespace ||
+         request->client_id().name_space == kAsyncNamespace)) {
+      request_ids.push_back(request->request_id());
     }
   }
   return request_ids;
 }
 
 void CancelRequestCallback(const RequestQueue::UpdateMultipleRequestResults&) {
   // Results ignored here, as UI uses observer to update itself.
 }
 
-void CancelRequestsContinuation(content::BrowserContext* browser_context,
-                                const std::string& guid,
-                                const std::vector<SavePageRequest>& requests) {
+void CancelRequestsContinuation(
+    content::BrowserContext* browser_context,
+    const std::string& guid,
+    std::vector<std::unique_ptr<SavePageRequest>> requests) {
   RequestCoordinator* coordinator =
       RequestCoordinatorFactory::GetForBrowserContext(browser_context);
   if (coordinator) {
-    std::vector<int64_t> request_ids = FilterRequestsByGuid(requests, guid);
+    std::vector<int64_t> request_ids =
+        FilterRequestsByGuid(std::move(requests), guid);
     coordinator->RemoveRequests(request_ids,
                                 base::Bind(&CancelRequestCallback));
   } else {
     LOG(WARNING) << "CancelRequestsContinuation has no valid coordinator.";
   }
 }
 
-void PauseRequestsContinuation(content::BrowserContext* browser_context,
-                               const std::string& guid,
-                               const std::vector<SavePageRequest>& requests) {
+void PauseRequestsContinuation(
+    content::BrowserContext* browser_context,
+    const std::string& guid,
+    std::vector<std::unique_ptr<SavePageRequest>> requests) {
   RequestCoordinator* coordinator =
       RequestCoordinatorFactory::GetForBrowserContext(browser_context);
   if (coordinator)
-    coordinator->PauseRequests(FilterRequestsByGuid(requests, guid));
+    coordinator->PauseRequests(FilterRequestsByGuid(std::move(requests), guid));
   else
     LOG(WARNING) << "PauseRequestsContinuation has no valid coordinator.";
 }
 
-void ResumeRequestsContinuation(content::BrowserContext* browser_context,
-                                const std::string& guid,
-                                const std::vector<SavePageRequest>& requests) {
+void ResumeRequestsContinuation(
+    content::BrowserContext* browser_context,
+    const std::string& guid,
+    std::vector<std::unique_ptr<SavePageRequest>> requests) {
   RequestCoordinator* coordinator =
       RequestCoordinatorFactory::GetForBrowserContext(browser_context);
   if (coordinator)
-    coordinator->ResumeRequests(FilterRequestsByGuid(requests, guid));
+    coordinator->ResumeRequests(
+        FilterRequestsByGuid(std::move(requests), guid));
   else
     LOG(WARNING) << "ResumeRequestsContinuation has no valid coordinator.";
 }
 
 }  // namespace
 
 OfflinePageDownloadBridge::OfflinePageDownloadBridge(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj,
     DownloadUIAdapter* download_ui_adapter,
@@ skipping 221 matching lines @@
 
   DownloadUIAdapter* adapter =
       DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
 
   return reinterpret_cast<jlong>(
       new OfflinePageDownloadBridge(env, obj, adapter, browser_context));
 }
 
 }  // namespace android
 }  // namespace offline_pages