Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2262403002: [DevTools] Fix V8 inspector compilation on SmartOS (Closed)

Created:
4 years, 4 months ago by eostroukhov
Modified:
4 years, 4 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix V8 inspector compilation on SmartOS SmartOS does not have snprintf in std namespace (even though it has the headers). This change imports global symbol into std namespace. R=dgozman@chromium.org, pfeldman@chromium.org BUG= Committed: https://crrev.com/202452fc4e5633afadb5ef5193efc20bbc3cc22f Cr-Commit-Position: refs/heads/master@{#413629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/PlatformSTL.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
eostroukhov-old
4 years, 4 months ago (2016-08-22 21:45:52 UTC) #3
dgozman
lgtm
4 years, 4 months ago (2016-08-22 21:46:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262403002/1
4 years, 4 months ago (2016-08-22 21:47:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/278506)
4 years, 4 months ago (2016-08-23 01:07:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262403002/1
4 years, 4 months ago (2016-08-23 01:10:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 02:01:18 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:04:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/202452fc4e5633afadb5ef5193efc20bbc3cc22f
Cr-Commit-Position: refs/heads/master@{#413629}

Powered by Google App Engine
This is Rietveld 408576698