src/debug/debug-scopes.cc - Issue 2262393004: Let LookupRecursive bind to NonLocals properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-scopes.cc

Issue 2262393004: Let LookupRecursive bind to NonLocals properly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-scopes.cc

diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc

index 55108bb96e47b8948031798da888b5241e2f871e..123e4cb7d139842c92c03ab72a566e26a664eee2 100644

--- a/src/debug/debug-scopes.cc

+++ b/src/debug/debug-scopes.cc

@@ -115,8 +115,7 @@ ScopeIterator::ScopeIterator(Isolate* isolate, FrameInspector* frame_inspector,

CollectNonLocals(info.get(), scope);

}

if (!ignore_nested_scopes) {

- AstNodeFactory ast_node_factory(info.get()->ast_value_factory());

- scope->AllocateVariables(info.get(), &ast_node_factory);

+ scope->AllocateVariables(info.get());

RetrieveScopeChain(scope);

}

} else if (!ignore_nested_scopes) {

« no previous file with comments | « src/ast/scopes.cc ('k') | no next file » | no next file with comments »