'Extract Local' and 'Inline Local' refactoring need only single file analysis.

'Extract Local' and 'Inline Local' refactoring need only single file analysis.

We still analyze more than we actually need - we don't need the full
RESOLVED_UNIT, we could live with some much lower RESOLVED_UNITx. But it
might be fast enough for practical purposes to compute fully resolved
units.

Maybe we should set up monitoring for refactoring times...


R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/90c7698f1bb8ac3f08a747215acb0ded799e7cc5

[Brian Wilkerson, 2016-08-22 23:32:23]

lgtm

https://codereview.chromium.org/2262393003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/2262393003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:728: subscriptionToReset =
server.onAnalysisStarted.listen((_) => _reset());
Should we assert that `subscriptionToReset` is null before we assign it, here
and below?

[scheglov, 2016-08-23 01:55:28]

https://codereview.chromium.org/2262393003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/2262393003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:728: subscriptionToReset =
server.onAnalysisStarted.listen((_) => _reset());
On 2016/08/22 23:32:23, Brian Wilkerson wrote:
> Should we assert that `subscriptionToReset` is null before we assign it, here
> and below?

Well, we need to at least cancel the current subscription, if it exists.
Done.

[scheglov, 2016-08-23 02:00:01]

Description was changed from

==========
'Extract Local' and 'Inline Local' refactoring need only single file analysis.

We still analyze more than we actually need - we don't need the full
RESOLVED_UNIT, we could live with some much lower RESOLVED_UNITx. But it
might be fast enough for practical purposes to compute fully resolved
units.

Maybe we should set up monitoring for refactoring times...


R=brianwilkerson@google.com
BUG=
==========

to

==========
'Extract Local' and 'Inline Local' refactoring need only single file analysis.

We still analyze more than we actually need - we don't need the full
RESOLVED_UNIT, we could live with some much lower RESOLVED_UNITx. But it
might be fast enough for practical purposes to compute fully resolved
units.

Maybe we should set up monitoring for refactoring times...


R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/90c7698f1bb8ac3f08a747215acb0ded799e7cc5
==========

[scheglov, 2016-08-23 02:00:02]

Committed patchset #1 (id:1) manually as
90c7698f1bb8ac3f08a747215acb0ded799e7cc5 (presubmit successful).