third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: indentation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-small-size-ancestor.html ('K') | « third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-small-size-ancestor.html ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 836c7e887028a725525e433a47fcb509e6a220ec..0322d90aa90340cdea7e32d471c688e387d5095d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -572,6 +572,8 @@ void LayoutBox::scrollRectToVisible(const LayoutRect& rect, const ScrollAlignmen

// Don't scroll to reveal an overflow layer that is restricted by the -webkit-line-clamp property.

// This will prevent us from revealing text hidden by the slider in Safari RSS.

newRect = getScrollableArea()->scrollIntoView(rect, alignX, alignY, scrollType);

+ if (newRect == LayoutRect())

bokan 2016/08/26 16:12:14 use newRect.isEmpty() instead

+ return;

} else if (!parentBox && canBeProgramaticallyScrolled()) {

if (FrameView* frameView = this->frameView()) {

HTMLFrameOwnerElement* ownerElement = document().localOwner();