third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the code style Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-small-size-ancestor.html ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

index 641417f3d2bf44d94f303ab047d8ab920b84f85e..d6b28f9e0399fadc7c118ef6921013573050dc0f 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

@@ -367,6 +367,8 @@ public:

bool hitTestResizerInFragments(const PaintLayerFragments&, const HitTestLocation&) const;

+ // Returns the new position, after scrolling, of the given rect in absolute

+ // coordinates, clipped by the parent's client rect.

LayoutRect scrollIntoView(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll) override;

// Returns true if scrollable area is in the FrameView's collection of scrollable areas. This can