third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-small-size-ancestor.html - Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-small-size-ancestor.html

Issue 2262373003: Clip PaintLayerScrollableArea::scrollIntoView return to layer bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: indentation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../../resources/testharness.js'></script>

	3 <script src='../../resources/testharnessreport.js'></script>

	4 <body>
	bokan 2016/08/26 16:12:14 Nit: remove <body> Nit: remove <body>
	5 <div id = 'space1' style = 'height: 200px'> </div>
	bokan 2016/08/26 16:12:14 If you're just using this for space, there's bette If you're just using this for space, there's better ways: Give the container a margin-top style Or Make container position: absolute; top: 200px
	6 <div id = 'container' style = 'height: 300px; overflow: auto;' >
	bokan 2016/08/26 16:12:14 Nit: no spaces between attribute, =, and value. i Nit: no spaces between attribute, =, and value. i.e. id = 'container' should be id='container' Also, please decide on either single or double quotes for attribute values and use them everywhere. (double quotes are probably more common for attribute values)
	7 <select id="content" multiple="multiple" style = 'height: 600px'>
	bokan 2016/08/26 16:12:14 Nit: Please indent the <select> Nit: Please indent the <select>
	8 <option>I</option>

	9 <option>am</option>

	10 <option>already</option>

	11 <option>in</option>

	12 <option>the</option>

	13 <option>view</option>

	14 <option>.</option>

	15 <option>Do</option>

	16 <option>not</option>

	17 <option>scroll</option>

	18 <option>me</option>

	19 <option>up</option>

	20 <option>.</option>

	21 </select>

	22 </div>

	23 <div id = 'space2' style = 'height: 600px'></div>

	24 </body>

	25

	26 <script>

	27 test(function(t) {

	28 var content = document.getElementById('content');

	29 content.focus();

	30 assert_equals(window.scrollY, 0);

	31 }, 'Tests that when the parent is already in the view of page, the page will not scroll the parent even when the child is not completely in the view.');

	32 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')