third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 2262363002: Ensure ImageBuffer is never used with ImageBitmapRenderingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2262363002: Ensure ImageBuffer is never used with ImageBitmapRenderingContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index f2bfec4694d5ea0db8288d6798317bef582b67cc..24b72195720eaa34ec09856fda4664c1c58a1923 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -983,6 +983,7 @@ SkCanvas* HTMLCanvasElement::existingDrawingCanvas() const

ImageBuffer* HTMLCanvasElement::buffer() const

{

DCHECK(m_context);

+ DCHECK(m_context->getContextType() != CanvasRenderingContext::ContextImageBitmap);

if (!hasImageBuffer() && !m_didFailToCreateImageBuffer)

const_cast<HTMLCanvasElement*>(this)->createImageBuffer();

return m_imageBuffer.get();

« no previous file with comments | « no previous file | no next file » | no next file with comments »