Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tools/perf/page_sets/key_mobile_sites_smooth.py

Issue 2262343002: Fix page interaction with CnnArticlePage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment for why this is needed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_mobile_sites_smooth.py
diff --git a/tools/perf/page_sets/key_mobile_sites_smooth.py b/tools/perf/page_sets/key_mobile_sites_smooth.py
index 200915991c0fa738fa683a25019fca8383ac6697..1891b118f6d36b2799bd60687a8c2934505b402a 100644
--- a/tools/perf/page_sets/key_mobile_sites_smooth.py
+++ b/tools/perf/page_sets/key_mobile_sites_smooth.py
@@ -125,6 +125,14 @@ class AmazonNicolasCageSmoothPage(
selector='#search',
distance_expr='document.body.scrollHeight - window.innerHeight')
+class CNNArticleSmoothPage(
+ key_mobile_sites_pages.CnnArticlePage):
+
+ def RunPageInteractions(self, action_runner):
+ with action_runner.CreateGestureInteraction('ScrollAction'):
+ # With default top_start_ratio=0.5 the corresponding element in this page
+ # will not be in the root scroller.
+ action_runner.ScrollPage(top_start_ratio=0.01)
class KeyMobileSitesSmoothPageSet(story.StorySet):
@@ -140,7 +148,6 @@ class KeyMobileSitesSmoothPageSet(story.StorySet):
predefined_page_classes = [
key_mobile_sites_pages.CapitolVolkswagenPage,
key_mobile_sites_pages.TheVergeArticlePage,
- key_mobile_sites_pages.CnnArticlePage,
key_mobile_sites_pages.FacebookPage,
key_mobile_sites_pages.YoutubeMobilePage,
key_mobile_sites_pages.YahooAnswersPage,
@@ -164,6 +171,7 @@ class KeyMobileSitesSmoothPageSet(story.StorySet):
# self.AddStory(GroupClonedListImagesSmoothPage(self))
self.AddStory(GoogleNewsMobile2SmoothPage(self))
self.AddStory(AmazonNicolasCageSmoothPage(self))
+ self.AddStory(CNNArticleSmoothPage(self))
# Add pages with custom labels.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698