Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2262333002: [WebApk] Update verification keys. (Closed)

Created:
4 years, 3 months ago by pkotwicz
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, dominickn+watch_chromium.org, Xi Han, hartmanng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebApk] Update verification keys. Update keys to latest test keys and also break it out by channel.

Patch Set 1 : Merge branch 'master' into yaron_cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -61 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +1 line, -55 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.template View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/android/webapk/channel_keys.h View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pkotwicz
Robert can you please take a look? This CL is 99.9% copied and pasted from ...
4 years, 3 months ago (2016-08-22 19:23:45 UTC) #4
Robert Sesek
lgtm
4 years, 3 months ago (2016-08-24 17:06:58 UTC) #5
pkotwicz
According to Glenn (ghartmann@), the new keys are suboptimal. I am waiting for new keys ...
4 years, 3 months ago (2016-08-26 23:43:20 UTC) #6
pkotwicz
4 years, 3 months ago (2016-09-13 21:44:52 UTC) #7
Abandoning this CL. Glenn landed this CL as part of
https://codereview.chromium.org/2317273002/

Powered by Google App Engine
This is Rietveld 408576698