Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226233002: Revert "Reland of https://codereview.chromium.org/172523002/" (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Revert "Reland of https://codereview.chromium.org/172523002/" This reverts commit r20516 due to a Sunspider performance issue. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -1185 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 5 chunks +41 lines, -147 lines 0 comments Download
M src/arm/debug-arm.cc View 3 chunks +20 lines, -11 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 9 chunks +61 lines, -26 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +46 lines, -161 lines 0 comments Download
M src/arm64/debug-arm64.cc View 3 chunks +20 lines, -11 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 9 chunks +62 lines, -25 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/code-stubs.h View 7 chunks +15 lines, -57 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/debug.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/debug.cc View 7 chunks +11 lines, -18 lines 0 comments Download
M src/full-codegen.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +39 lines, -150 lines 0 comments Download
M src/ia32/debug-ia32.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 10 chunks +63 lines, -26 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 3 chunks +0 lines, -127 lines 0 comments Download
M src/ic.cc View 7 chunks +3 lines, -165 lines 0 comments Download
M src/log.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/v8globals.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +41 lines, -152 lines 0 comments Download
M src/x64/debug-x64.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 9 chunks +63 lines, -27 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Igor, PTAL, --Michael
6 years, 8 months ago (2014-04-04 16:16:48 UTC) #1
Igor Sheludko
rubber stamp lgtm
6 years, 8 months ago (2014-04-04 16:17:42 UTC) #2
mvstanton
6 years, 8 months ago (2014-04-04 16:19:32 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r20521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698