Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing caseq comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 var relatedNodeLabel; 695 var relatedNodeLabel;
696 696
697 var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.targ etByEvent(event), linkifier); 697 var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.targ etByEvent(event), linkifier);
698 contentHelper.addSection(WebInspector.TimelineUIUtils.eventTitle(event), Web Inspector.TimelineUIUtils.eventStyle(event).category); 698 contentHelper.addSection(WebInspector.TimelineUIUtils.eventTitle(event), Web Inspector.TimelineUIUtils.eventStyle(event).category);
699 699
700 var eventData = event.args["data"]; 700 var eventData = event.args["data"];
701 var initiator = event.initiator; 701 var initiator = event.initiator;
702 702
703 if (event.warning) 703 if (event.warning)
704 contentHelper.appendWarningRow(event); 704 contentHelper.appendWarningRow(event);
705 if (event.name === recordTypes.JSFrame) { 705 if (event.name === recordTypes.JSFrame && eventData["deoptReason"])
706 var deoptReason = eventData["deoptReason"]; 706 contentHelper.appendWarningRow(event, WebInspector.TimelineModel.Warning Type.V8Deopt);
707 if (deoptReason && deoptReason !== "no reason")
708 contentHelper.appendWarningRow(event, WebInspector.TimelineModel.War ningType.V8Deopt);
709 }
710 707
711 if (detailed) { 708 if (detailed) {
712 contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.m illisToString(event.selfTime, true)); 709 contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.m illisToString(event.selfTime, true));
713 contentHelper.appendTextRow(WebInspector.UIString("Total Time"), Number. millisToString(event.duration || 0, true)); 710 contentHelper.appendTextRow(WebInspector.UIString("Total Time"), Number. millisToString(event.duration || 0, true));
714 } 711 }
715 712
716 switch (event.name) { 713 switch (event.name) {
717 case recordTypes.GCEvent: 714 case recordTypes.GCEvent:
718 case recordTypes.MajorGC: 715 case recordTypes.MajorGC:
719 case recordTypes.MinorGC: 716 case recordTypes.MinorGC:
(...skipping 1427 matching lines...) Expand 10 before | Expand all | Expand 10 after
2147 case warnings.V8Deopt: 2144 case warnings.V8Deopt:
2148 span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/Googl eChrome/devtools-docs/issues/53", 2145 span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/Googl eChrome/devtools-docs/issues/53",
2149 WebInspector.UIString("Not optimized"), undefined, true)); 2146 WebInspector.UIString("Not optimized"), undefined, true));
2150 span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReaso n"])); 2147 span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReaso n"]));
2151 break; 2148 break;
2152 default: 2149 default:
2153 console.assert(false, "Unhandled TimelineModel.WarningType"); 2150 console.assert(false, "Unhandled TimelineModel.WarningType");
2154 } 2151 }
2155 return span; 2152 return span;
2156 } 2153 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698