Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2262303002: DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing caseq comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {!WebInspector.TimelineModel} model 8 * @param {!WebInspector.TimelineModel} model
9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters 9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters
10 */ 10 */
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 var name = container.createChild("div", "activity-name"); 338 var name = container.createChild("div", "activity-name");
339 var event = this._profileNode.event; 339 var event = this._profileNode.event;
340 if (this._profileNode.isGroupNode()) { 340 if (this._profileNode.isGroupNode()) {
341 var treeView = /** @type {!WebInspector.AggregatedTimelineTreeView} */ (this._treeView); 341 var treeView = /** @type {!WebInspector.AggregatedTimelineTreeView} */ (this._treeView);
342 var info = treeView._displayInfoForGroupNode(this._profileNode); 342 var info = treeView._displayInfoForGroupNode(this._profileNode);
343 name.textContent = info.name; 343 name.textContent = info.name;
344 icon.style.backgroundColor = info.color; 344 icon.style.backgroundColor = info.color;
345 } else if (event) { 345 } else if (event) {
346 var data = event.args["data"]; 346 var data = event.args["data"];
347 var deoptReason = data && data["deoptReason"]; 347 var deoptReason = data && data["deoptReason"];
348 if (deoptReason && deoptReason !== "no reason") 348 if (deoptReason)
349 container.createChild("div", "activity-warning").title = WebInsp ector.UIString("Not optimized: %s", deoptReason); 349 container.createChild("div", "activity-warning").title = WebInsp ector.UIString("Not optimized: %s", deoptReason);
350 name.textContent = event.name === WebInspector.TimelineModel.RecordT ype.JSFrame 350 name.textContent = event.name === WebInspector.TimelineModel.RecordT ype.JSFrame
351 ? WebInspector.beautifyFunctionName(event.args["data"]["function Name"]) 351 ? WebInspector.beautifyFunctionName(event.args["data"]["function Name"])
352 : WebInspector.TimelineUIUtils.eventTitle(event); 352 : WebInspector.TimelineUIUtils.eventTitle(event);
353 var link = this._treeView._linkifyLocation(event); 353 var link = this._treeView._linkifyLocation(event);
354 if (link) 354 if (link)
355 container.createChild("div", "activity-link").appendChild(link); 355 container.createChild("div", "activity-link").appendChild(link);
356 icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor (event); 356 icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor (event);
357 } 357 }
358 return cell; 358 return cell;
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode; 879 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode;
880 }, 880 },
881 881
882 _onSelectionChanged: function() 882 _onSelectionChanged: function()
883 { 883 {
884 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged); 884 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged);
885 }, 885 },
886 886
887 __proto__: WebInspector.VBox.prototype 887 __proto__: WebInspector.VBox.prototype
888 } 888 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698