chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc - Issue 22623002: Extract AutofillDialogController interface and common utilities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

Issue 22623002: Extract AutofillDialogController interface and common utilities. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: removed irrelevant tests. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_controller.cc ('K') | « chrome/browser/ui/autofill/autofill_dialog_controller.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

index 6aa1712e91b5d520e75ade5debea03cebe726ca8..136a0867b25a846ed419164480721a9ce9260db8 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

@@ -140,7 +140,7 @@ class TestAutofillDialogController : public AutofillDialogControllerImpl {

section, inputs, validation_type);

}

- // Saving to Chrome is tested in AutofillDialogController unit tests.

+ // Saving to Chrome is tested in AutofillDialogControllerImpl unit tests.

// TODO(estade): test that the view defaults to saving to Chrome.

virtual bool ShouldOfferToSaveInChrome() const OVERRIDE {

return false;

@@ -301,7 +301,8 @@ class AutofillDialogControllerTest : public InProcessBrowserTest {

ExpectDomMessage("clicked");

AutofillDialogControllerImpl* controller =

- delegate->GetDialogControllerForTesting();

+ static_cast<AutofillDialogControllerImpl*>(

+ delegate->GetDialogControllerForTesting());

DCHECK(controller);

return controller;

}