Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2262263002: Remove quantization of device-space dest rect for Ganesh analytic rrect blurs (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove quantization of device-space dest rect for Ganesh analytic rrect blurs At least on Windows, this fixes a lot of the horrible banded blurs. AFAICT there is no good reason to quantize the device space rect passed to the GrRectBlurEffect. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2262263002 Committed: https://skia.googlesource.com/skia/+/3a0c3696f0ece5e408baf9d1ed14251ba7a223e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 4 months ago (2016-08-22 17:27:57 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-22 17:53:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262263002/1
4 years, 4 months ago (2016-08-22 18:47:51 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:48:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a0c3696f0ece5e408baf9d1ed14251ba7a223e3

Powered by Google App Engine
This is Rietveld 408576698