Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2262243002: Build "all" on the CrWinAsan bots

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Build "all" on the CrWinAsan bots Some stuff broke during the gn switch, and we didn't notice. Make sure we notice it next time. It'll make the bots a bit slower, but it makes them match the non-asan bots too, which seems like a good thing. BUG=636399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 3 chunks +12 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan.json View 1 chunk +1 line, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsanCov.json View 1 chunk +1 line, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_dll_.json View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
Nico
Landing this is blocked on the bot being green again and it actually building 'all' ...
4 years, 4 months ago (2016-08-22 16:05:39 UTC) #4
hans
4 years, 4 months ago (2016-08-22 16:15:47 UTC) #7
lgtm for the change itself

Powered by Google App Engine
This is Rietveld 408576698