Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/BUILD.gn

Issue 226223006: Template invocation fixes in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/BUILD.gn ('K') | « base/BUILD.gn ('k') | tools/gn/import_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index e0426ebfd92ea8857109f9c0f88c67ec66dd7670..0f4eb016ae4de60dc2d663318f0c6051e739d1be 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -174,6 +174,10 @@ config("default_libs") {
"winmm.lib",
"winspool.lib",
"ws2_32.lib",
+ # Please don't add more stuff here. We should actually be making this
+ # list smaller, since all common things should be covered. If you need
+ # some extra libraries, please just add a libs = [ "foo.lib" ] to your
+ # target that needs it.
]
} else if (is_android) {
# Android uses -nostdlib so we need to add even libc here.
« base/BUILD.gn ('K') | « base/BUILD.gn ('k') | tools/gn/import_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698