Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2262183002: [NoStatePrefetch] Do not send responses to renderer in prefetch mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefetchProto
Patch Set: remove TODO Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 13eaab6f81e960972585aca667242ed913bfe7b9..88bc31a765fa385ee13a7fe8fca008a812d465ef 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1570,12 +1570,19 @@ ResourceDispatcherHostImpl::CreateResourceHandler(
}
}
+ bool start_detached = request_data.download_to_network_cache_only;
+
// Prefetches and <a ping> requests outlive their child process.
- if (!sync_result && IsDetachableResourceType(request_data.resource_type)) {
- handler.reset(new DetachableResourceHandler(
- request,
- base::TimeDelta::FromMilliseconds(kDefaultDetachableCancelDelayMs),
- std::move(handler)));
+ if (!sync_result && (start_detached ||
+ IsDetachableResourceType(request_data.resource_type))) {
+ std::unique_ptr<DetachableResourceHandler> detachable_handler =
+ base::MakeUnique<DetachableResourceHandler>(
+ request,
+ base::TimeDelta::FromMilliseconds(kDefaultDetachableCancelDelayMs),
+ std::move(handler));
+ if (start_detached)
+ detachable_handler->Detach();
+ handler = std::move(detachable_handler);
}
// PlzNavigate: If using --enable-browser-side-navigation, the
« no previous file with comments | « no previous file | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | content/common/resource_request.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698