Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2262183002: [NoStatePrefetch] Do not send responses to renderer in prefetch mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefetchProto
Patch Set: Cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index a1b1f7b1df531921974518a8956c6588f6e0651d..2eab3eabc36e3420eeec075d78a4f7825d76579c 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -1493,6 +1493,51 @@ TEST_P(ResourceDispatcherHostTest, Cancel) {
EXPECT_EQ(0, network_delegate()->error_count());
}
+TEST_P(ResourceDispatcherHostTest, DownloadToNetworkCache) {
+ // Normal request.
+ MakeTestRequest(0, 1, net::URLRequestTestJob::test_url_2());
+
+ // Cache-only request.
+ ResourceRequest request_to_cache = CreateResourceRequest(
+ "GET", RESOURCE_TYPE_IMAGE, net::URLRequestTestJob::test_url_3());
+ request_to_cache.download_to_network_cache_only = true;
+ ResourceHostMsg_RequestResource msg_to_cache(0, 2, request_to_cache);
+ host_.OnMessageReceived(msg_to_cache, filter_.get());
+
+ KickOffRequest();
+
+ // The handler for the cache-only request should have been detached now.
+ GlobalRequestID global_request_id(filter_->child_id(), 2);
+ ResourceRequestInfoImpl* info = ResourceRequestInfoImpl::ForRequest(
+ host_.GetURLRequest(global_request_id));
+ ASSERT_TRUE(info->detachable_handler()->is_detached());
+
+ // Flush all the pending requests.
+ while (net::URLRequestTestJob::ProcessOnePendingMessage()) {}
+ base::RunLoop().RunUntilIdle();
+
+ // Everything should be out now.
+ EXPECT_EQ(0, host_.pending_requests());
+
+ ResourceIPCAccumulator::ClassifiedMessages msgs;
+ accum_.GetClassifiedMessages(&msgs);
+
+ // there are two requests, so we should have gotten them classified as such.
mmenke 2016/08/25 19:36:43 nit: Capitalize "There"
+ ASSERT_EQ(2U, msgs.size());
+
+ // The normal request succeeded.
+ CheckSuccessfulRequest(msgs[0], net::URLRequestTestJob::test_data_2());
+
+ // The cache-only request got canceled, as far as the renderer is concerned.
+ ASSERT_EQ(1U, msgs[1].size());
+ CheckRequestCompleteErrorCode(msgs[1][0], net::ERR_ABORTED);
+
+ // However, all requests should have actually gone to completion.
+ EXPECT_EQ(2, network_delegate()->completed_requests());
+ EXPECT_EQ(0, network_delegate()->canceled_requests());
+ EXPECT_EQ(0, network_delegate()->error_count());
+}
+
// Shows that detachable requests will timeout if the request takes too long to
// complete.
TEST_P(ResourceDispatcherHostTest, DetachedResourceTimesOut) {

Powered by Google App Engine
This is Rietveld 408576698