Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2262143002:
Fix some outdated test cases in PasswordFormManagerTest (Closed)
|
Created:
4 years, 4 months ago by vabr (Chromium) Modified:
4 years, 4 months ago Reviewers:
dvadym CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@621355_owned-by-FormFetcher Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix some outdated test cases in PasswordFormManagerTest
This CL removes TestForceInclusionOfGeneratedPasswords_NoMatch and fixes
CorrectlyUpdatePasswordsWithSameUsername. The former is outdated and replaced
by other test cases. The latter created the unrealistic situation of multiple
stored credentials with the same unique key -- the fix is to slightly tweak the
unique key. More details on the bug.
BUG=639678
Committed: https://crrev.com/d31632b608b6168a0b923aa08f46338186a1809f
Cr-Commit-Position: refs/heads/master@{#414054}
Patch Set 1 #Patch Set 2 : Just rebased #Patch Set 3 : Just rebased #Patch Set 4 : Just rebased #Patch Set 5 : Just rebased #Patch Set 6 : Just rebased #Messages
Total messages: 29 (24 generated)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
vabr@chromium.org changed reviewers: + dvadym@chromium.org
Hi Vadym, This is another CL in the row :). Fortunately a smaller than the last one, fixing some tests. PTAL. Thanks, Vaclav
On 2016/08/24 08:50:33, vabr (Chromium) wrote: > Hi Vadym, > > This is another CL in the row :). Fortunately a smaller than the last one, > fixing some tests. PTAL. > > Thanks, > Vaclav LGTM Thanks for improving tests.
The CQ bit was checked by vabr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org Link to the patchset: https://codereview.chromium.org/2262143002/#ps100001 (title: "Just rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Fix some outdated test cases in PasswordFormManagerTest This CL removes TestForceInclusionOfGeneratedPasswords_NoMatch and fixes CorrectlyUpdatePasswordsWithSameUsername. The former is outdated and replaced by other test cases. The latter created the unrealistic situation of multiple stored credentials with the same unique key -- the fix is to slightly tweak the unique key. More details on the bug. BUG=639678 ========== to ========== Fix some outdated test cases in PasswordFormManagerTest This CL removes TestForceInclusionOfGeneratedPasswords_NoMatch and fixes CorrectlyUpdatePasswordsWithSameUsername. The former is outdated and replaced by other test cases. The latter created the unrealistic situation of multiple stored credentials with the same unique key -- the fix is to slightly tweak the unique key. More details on the bug. BUG=639678 Committed: https://crrev.com/d31632b608b6168a0b923aa08f46338186a1809f Cr-Commit-Position: refs/heads/master@{#414054} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/d31632b608b6168a0b923aa08f46338186a1809f Cr-Commit-Position: refs/heads/master@{#414054} |
