Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2262133002: Simplify Scope::AllowsLazyCompilationWithoutContext (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify Scope::AllowsLazyCompilationWithoutContext Now it just relies on NeedsContext and hence is guaranteed to be in sync. BUG=v8:5209 Committed: https://crrev.com/72b784426d916c36da9f7d5b171fe33c5fb9eee3 Cr-Commit-Position: refs/heads/master@{#38771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -40 lines) Patch
M src/ast/scopes.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/ast/scopes.cc View 3 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal, thanks for the suggestion!
4 years, 4 months ago (2016-08-22 08:33:46 UTC) #2
neis
lgtm
4 years, 4 months ago (2016-08-22 08:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262133002/1
4 years, 4 months ago (2016-08-22 08:38:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 09:02:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 09:02:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72b784426d916c36da9f7d5b171fe33c5fb9eee3
Cr-Commit-Position: refs/heads/master@{#38771}

Powered by Google App Engine
This is Rietveld 408576698