Allow rewriting of Flash embeds in PluginDocument.

Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
TEST=fuzzer

Committed: https://crrev.com/3fa2f0b980f25c83408ff33a6d2f97ed628ff8bf
Cr-Commit-Position: refs/heads/master@{#413564}

[mlamouri (slow - plz ping), 2016-08-22 06:27:33]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 06:27:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 10:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 10:09:30]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-08-22 16:03:57]

Description was changed from

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=None
==========

to

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
==========

[mlamouri (slow - plz ping), 2016-08-22 16:05:35]

Description was changed from

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
==========

to

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
TEST=fuzzer
==========

[mlamouri (slow - plz ping), 2016-08-22 16:10:32]

mlamouri@chromium.org changed reviewers:
+ pdr@chromium.org

[mlamouri (slow - plz ping), 2016-08-22 16:10:32]

I tried locally and it should fix the issue. I think it is a better fix than
preventing rewrite in PluginDocument. Looking more deeply, users of
PluginDocment assume that the Widget can be null, they just expect it to be a
plugin container if it is not. The new simple check helps matching callers
expectations.

[pdr., 2016-08-22 18:04:02]

On 2016/08/22 at 16:10:32, mlamouri wrote:
> I tried locally and it should fix the issue. I think it is a better fix than
preventing rewrite in PluginDocument. Looking more deeply, users of
PluginDocment assume that the Widget can be null, they just expect it to be a
plugin container if it is not. The new simple check helps matching callers
expectations.

LGTM

[mlamouri (slow - plz ping), 2016-08-22 22:42:48]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:43:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:49:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 22:50:57]

Description was changed from

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
TEST=fuzzer
==========

to

==========
Allow rewriting of Flash embeds in PluginDocument.

This is writing a real fix for the crash that was caused instead of
avoididng rewriting embeds inside a PluginDocument.

BUG=636226
TEST=fuzzer

Committed: https://crrev.com/3fa2f0b980f25c83408ff33a6d2f97ed628ff8bf
Cr-Commit-Position: refs/heads/master@{#413564}
==========

[commit-bot: I haz the power, 2016-08-22 22:50:58]

Patchset 1 (id:??) landed as
https://crrev.com/3fa2f0b980f25c83408ff33a6d2f97ed628ff8bf
Cr-Commit-Position: refs/heads/master@{#413564}