Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2262043003: Fix a couple socket tests for short read/write (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a couple socket tests for short read/write It appears to be timing dependent whether a SocketException or a HandshakeException is thrown in the presence of short reads and writes for these secure socket tests that are meant to fail. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/e0f5ed22b9265ce5fd7264fc0d71ee9c562d5a6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
zra
4 years, 3 months ago (2016-08-22 20:03:22 UTC) #5
siva
lgtm
4 years, 3 months ago (2016-08-22 20:34:07 UTC) #6
zra
4 years, 3 months ago (2016-08-22 20:45:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0f5ed22b9265ce5fd7264fc0d71ee9c562d5a6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698