Source/core/rendering/RenderBlock.cpp - Issue 226203010: [CSS Shapes] shape-outside from image doesn't load properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 226203010: [CSS Shapes] shape-outside from image doesn't load properly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Revised the test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index 5947b2ec0cb838ce16275e20b61f85b996504a47..1a636a2d48a144a2d82525399151a0892b32c0d4 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -215,6 +215,8 @@ static void appendImagesFromStyle(Vector<ImageResource*>& images, RenderStyle& b

appendImageIfNotNull(images, blockStyle.listStyleImage());

appendImageIfNotNull(images, blockStyle.borderImageSource());

appendImageIfNotNull(images, blockStyle.maskBoxImageSource());

+ if (blockStyle.shapeOutside())

+ appendImageIfNotNull(images, blockStyle.shapeOutside()->image());

}

RenderBlock::~RenderBlock()

« no previous file with comments | « LayoutTests/http/tests/css/shape-image-file-expected.html ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderBox.cpp » ('J')