[CSS Shapes] shape-outside from image doesn't load properly

[CSS Shapes] shape-outside from image doesn't load properly

Corrected a set of problems related to shape-outside image loading:

- Make RenderImage::imageChanged() call super if there's a shape-outside image, because the shape-outside imageChanged() logic is in RenderBox.

- Added the shape-outside image to appendImagesFromStyle().

- Moved the logic from RenderObject::removeShapeImageClient() from RenderObject::postDestroy() to RenderBox::willDestroy() because it's simpler that way.


BUG=360668
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171303

[Hans Muller, 2014-04-10 00:37:21]

Some small changes that improve the way an image-valued shape-outside works when
it's specified for an IMG element.

[eseidel, 2014-04-10 00:39:10]

It's best if someone more familiar with shapes reviews these first (even if they
aren't officially a core/OWNER yet).

But rslgtm.

[Hans Muller, 2014-04-10 00:42:42]

On 2014/04/10 00:39:10, eseidel wrote:
> It's best if someone more familiar with shapes reviews these first (even if
they
> aren't officially a core/OWNER yet).
> 
> But rslgtm.

OK, I'll make one of the other shapes developers takes a look before I try and
commit the patch.

[rwlbuis, 2014-04-10 15:05:55]

lgtm with the one nit.

https://codereview.chromium.org/226203010/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/226203010/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:116: if (shapeValue) {
Nit: you could inline the shapeValue into the if statement like below. I think
it is important to be consistent.

[Hans Muller, 2014-04-10 15:23:41]

On 2014/04/10 15:05:55, rwlbuis wrote:
> lgtm with the one nit.
> 
>
https://codereview.chromium.org/226203010/diff/20001/Source/core/rendering/Re...
> File Source/core/rendering/RenderBox.cpp (right):
> 
>
https://codereview.chromium.org/226203010/diff/20001/Source/core/rendering/Re...
> Source/core/rendering/RenderBox.cpp:116: if (shapeValue) {
> Nit: you could inline the shapeValue into the if statement like below. I think
> it is important to be consistent.

Thanks, that's a good point.  I've made the change.

[Hans Muller, 2014-04-10 15:23:50]

The CQ bit was checked by hmuller@adobe.com

[commit-bot: I haz the power, 2014-04-10 15:23:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hmuller@adobe.com/226203010/40001

[commit-bot: I haz the power, 2014-04-10 15:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 15:38:35]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Hans Muller, 2014-04-10 15:59:47]

The CQ bit was checked by hmuller@adobe.com

[commit-bot: I haz the power, 2014-04-10 15:59:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hmuller@adobe.com/226203010/40001

[commit-bot: I haz the power, 2014-04-10 16:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 16:09:51]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Hans Muller, 2014-04-10 16:47:11]

The CQ bit was checked by hmuller@adobe.com

[commit-bot: I haz the power, 2014-04-10 16:47:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hmuller@adobe.com/226203010/40001

[commit-bot: I haz the power, 2014-04-10 16:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 16:57:26]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[Hans Muller, 2014-04-10 20:00:08]

The CQ bit was checked by hmuller@adobe.com

[commit-bot: I haz the power, 2014-04-10 20:00:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hmuller@adobe.com/226203010/60001

[commit-bot: I haz the power, 2014-04-10 21:05:52]

Change committed as 171303