third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h - Issue 2262023002: Worker: Wait for termination by WorkerThreadLifecycleObserver instead of WaitableEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h

Issue 2262023002: Worker: Wait for termination by WorkerThreadLifecycleObserver instead of WaitableEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h b/third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h

index 323b054fa24f4794bcad6701207861c4ba1e64d8..76e055302b46ae413017997ef01b4fe72d260086 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h

+++ b/third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h

@@ -29,6 +29,7 @@ class WorkerThreadLifecycleContext;

class CORE_EXPORT WorkerThreadLifecycleObserver : public LifecycleObserver<WorkerThreadLifecycleContext, WorkerThreadLifecycleObserver> {

protected:

explicit WorkerThreadLifecycleObserver(WorkerThreadLifecycleContext*);

+ virtual ~WorkerThreadLifecycleObserver();

bool wasContextDestroyedBeforeObserverCreation() const

{