Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.h

Issue 2262023002: Worker: Wait for termination by WorkerThreadLifecycleObserver instead of WaitableEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/workers/WorkerThread.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.h b/third_party/WebKit/Source/core/workers/WorkerThread.h
index 76c05fb3705ec9abc833b1f6d48f3f30416a3cb5..2bf6cee53d760d4c10d82493ef5d26bf5b0e098c 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThread.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThread.h
@@ -114,11 +114,6 @@ public:
virtual bool shouldAttachThreadDebugger() const { return true; }
v8::Isolate* isolate();
- // Can be used to wait for this worker thread to terminate.
- // (This is signaled on the main thread, so it's assumed to be waited on
- // the worker context thread)
- WaitableEvent* terminationEvent() { return m_terminationEvent.get(); }
-
bool isCurrentThread();
WorkerLoaderProxy* workerLoaderProxy() const
@@ -239,9 +234,6 @@ private:
Persistent<WorkerOrWorkletGlobalScope> m_globalScope;
Persistent<WorkerInspectorController> m_workerInspectorController;
- // Signaled when the thread starts termination on the main thread.
- std::unique_ptr<WaitableEvent> m_terminationEvent;
-
// Signaled when the thread completes termination on the worker thread.
std::unique_ptr<WaitableEvent> m_shutdownEvent;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698