Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2262013002: Blink-compatible serialization of RegExp objects. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@vs-value
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of RegExp objects. BUG=chromium:148757 Committed: https://crrev.com/c4874b2fef73f76001a005fee2514ee0b48907a3 Cr-Commit-Position: refs/heads/master@{#38835}

Patch Set 1 #

Patch Set 2 : Merge branch 'vs-value' into vs-regexp #

Patch Set 3 : Merge branch 'vs-value' into vs-regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M src/value-serializer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 2 5 chunks +34 lines, -0 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jbroman
4 years, 4 months ago (2016-08-21 21:16:35 UTC) #4
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-22 17:50:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262013002/40001
4 years, 4 months ago (2016-08-23 14:38:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-23 15:16:20 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 15:16:38 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4874b2fef73f76001a005fee2514ee0b48907a3
Cr-Commit-Position: refs/heads/master@{#38835}

Powered by Google App Engine
This is Rietveld 408576698