third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

index 867c2297ce28b380888feab6a88bc4d937b98820..2ed225f0a1fd200e0f05be0cb6d9c0304de6e147 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

@@ -57,10 +57,11 @@ WebInspector.BreakpointManager = function(breakpointsSetting, workspace, network

this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);

}

+/** @enum {symbol} */

WebInspector.BreakpointManager.Events = {

- BreakpointAdded: "breakpoint-added",

- BreakpointRemoved: "breakpoint-removed",

- BreakpointsActiveStateChanged: "BreakpointsActiveStateChanged"

+ BreakpointAdded: Symbol("breakpoint-added"),

+ BreakpointRemoved: Symbol("breakpoint-removed"),

+ BreakpointsActiveStateChanged: Symbol("BreakpointsActiveStateChanged")

}

/**