Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.IndexingWorked, this._onIndexingWorked, this); 49 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.IndexingWorked, this._onIndexingWorked, this);
50 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.IndexingDone, this._onIndexingDone, this); 50 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.IndexingDone, this._onIndexingDone, this);
51 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.SearchCompleted, this._onSearchCompleted, this); 51 InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Event s.SearchCompleted, this._onSearchCompleted, this);
52 52
53 this._initExcludePatterSetting(); 53 this._initExcludePatterSetting();
54 } 54 }
55 55
56 /** @typedef {!{fileSystemName: string, rootURL: string, fileSystemPath: string} } */ 56 /** @typedef {!{fileSystemName: string, rootURL: string, fileSystemPath: string} } */
57 WebInspector.IsolatedFileSystemManager.FileSystem; 57 WebInspector.IsolatedFileSystemManager.FileSystem;
58 58
59 /** @enum {symbol} */
59 WebInspector.IsolatedFileSystemManager.Events = { 60 WebInspector.IsolatedFileSystemManager.Events = {
60 FileSystemAdded: "FileSystemAdded", 61 FileSystemAdded: Symbol("FileSystemAdded"),
61 FileSystemRemoved: "FileSystemRemoved", 62 FileSystemRemoved: Symbol("FileSystemRemoved"),
62 FileSystemsLoaded: "FileSystemsLoaded", 63 FileSystemsLoaded: Symbol("FileSystemsLoaded"),
63 FileSystemFilesChanged: "FileSystemFilesChanged", 64 FileSystemFilesChanged: Symbol("FileSystemFilesChanged"),
64 ExcludedFolderAdded: "ExcludedFolderAdded", 65 ExcludedFolderAdded: Symbol("ExcludedFolderAdded"),
65 ExcludedFolderRemoved: "ExcludedFolderRemoved" 66 ExcludedFolderRemoved: Symbol("ExcludedFolderRemoved")
66 } 67 }
67 68
68 WebInspector.IsolatedFileSystemManager._lastRequestId = 0; 69 WebInspector.IsolatedFileSystemManager._lastRequestId = 0;
69 70
70 /** 71 /**
71 * @param {string} fileSystemPath 72 * @param {string} fileSystemPath
72 * @return {string} 73 * @return {string}
73 */ 74 */
74 WebInspector.IsolatedFileSystemManager.normalizePath = function(fileSystemPath) 75 WebInspector.IsolatedFileSystemManager.normalizePath = function(fileSystemPath)
75 { 76 {
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 InspectorFrontendHost.events.removeEventListener(InspectorFrontendHostAP I.Events.SearchCompleted, this._onSearchCompleted, this); 364 InspectorFrontendHost.events.removeEventListener(InspectorFrontendHostAP I.Events.SearchCompleted, this._onSearchCompleted, this);
364 }, 365 },
365 366
366 __proto__: WebInspector.Object.prototype 367 __proto__: WebInspector.Object.prototype
367 } 368 }
368 369
369 /** 370 /**
370 * @type {!WebInspector.IsolatedFileSystemManager} 371 * @type {!WebInspector.IsolatedFileSystemManager}
371 */ 372 */
372 WebInspector.isolatedFileSystemManager; 373 WebInspector.isolatedFileSystemManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698