Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 315
316 /** 316 /**
317 * @param {!CanvasRenderingContext2D} context 317 * @param {!CanvasRenderingContext2D} context
318 * @param {number} x 318 * @param {number} x
319 * @param {number} height 319 * @param {number} height
320 * @param {number} pixelsPerMillisecond 320 * @param {number} pixelsPerMillisecond
321 */ 321 */
322 draw: function(context, x, height, pixelsPerMillisecond) { }, 322 draw: function(context, x, height, pixelsPerMillisecond) { },
323 } 323 }
324 324
325 /** @enum {symbol} */
325 WebInspector.FlameChart.Events = { 326 WebInspector.FlameChart.Events = {
326 EntrySelected: "EntrySelected" 327 EntrySelected: Symbol("EntrySelected")
327 } 328 }
328 329
329 330
330 /** 331 /**
331 * @constructor 332 * @constructor
332 * @param {!{min: number, max: number}|number=} hueSpace 333 * @param {!{min: number, max: number}|number=} hueSpace
333 * @param {!{min: number, max: number, count: (number|undefined)}|number=} satSp ace 334 * @param {!{min: number, max: number, count: (number|undefined)}|number=} satSp ace
334 * @param {!{min: number, max: number, count: (number|undefined)}|number=} light nessSpace 335 * @param {!{min: number, max: number, count: (number|undefined)}|number=} light nessSpace
335 * @param {!{min: number, max: number, count: (number|undefined)}|number=} alpha Space 336 * @param {!{min: number, max: number, count: (number|undefined)}|number=} alpha Space
336 */ 337 */
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
2019 this.update(); 2020 this.update();
2020 }, 2021 },
2021 2022
2022 _enabled: function() 2023 _enabled: function()
2023 { 2024 {
2024 return this._rawTimelineDataLength !== 0; 2025 return this._rawTimelineDataLength !== 0;
2025 }, 2026 },
2026 2027
2027 __proto__: WebInspector.HBox.prototype 2028 __proto__: WebInspector.HBox.prototype
2028 } 2029 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698