Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 /** @type {!Array.<!WebInspector.TabbedPaneTab>} */ 52 /** @type {!Array.<!WebInspector.TabbedPaneTab>} */
53 this._tabsHistory = []; 53 this._tabsHistory = [];
54 /** @type {!Object.<string, !WebInspector.TabbedPaneTab>} */ 54 /** @type {!Object.<string, !WebInspector.TabbedPaneTab>} */
55 this._tabsById = {}; 55 this._tabsById = {};
56 this._currentTabLocked = false; 56 this._currentTabLocked = false;
57 57
58 this._dropDownButton = this._createDropDownButton(); 58 this._dropDownButton = this._createDropDownButton();
59 WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.Zo omChanged, this._zoomChanged, this); 59 WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.Zo omChanged, this._zoomChanged, this);
60 } 60 }
61 61
62 /** @enum {symbol} */
62 WebInspector.TabbedPane.EventTypes = { 63 WebInspector.TabbedPane.EventTypes = {
63 TabSelected: "TabSelected", 64 TabSelected: Symbol("TabSelected"),
64 TabClosed: "TabClosed", 65 TabClosed: Symbol("TabClosed"),
65 TabOrderChanged: "TabOrderChanged" 66 TabOrderChanged: Symbol("TabOrderChanged")
66 } 67 }
67 68
68 WebInspector.TabbedPane.prototype = { 69 WebInspector.TabbedPane.prototype = {
69 /** 70 /**
70 * @param {boolean} locked 71 * @param {boolean} locked
71 */ 72 */
72 setCurrentTabLocked: function(locked) 73 setCurrentTabLocked: function(locked)
73 { 74 {
74 this._currentTabLocked = locked; 75 this._currentTabLocked = locked;
75 this._headerElement.classList.toggle("locked", this._currentTabLocked); 76 this._headerElement.classList.toggle("locked", this._currentTabLocked);
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
1239 * @param {!Array.<string>} ids 1240 * @param {!Array.<string>} ids
1240 */ 1241 */
1241 closeTabs: function(tabbedPane, ids) { }, 1242 closeTabs: function(tabbedPane, ids) { },
1242 1243
1243 /** 1244 /**
1244 * @param {string} tabId 1245 * @param {string} tabId
1245 * @param {!WebInspector.ContextMenu} contextMenu 1246 * @param {!WebInspector.ContextMenu} contextMenu
1246 */ 1247 */
1247 onContextMenu: function(tabId, contextMenu) { } 1248 onContextMenu: function(tabId, contextMenu) { }
1248 } 1249 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698