Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 /** @typedef {{showMode: string, size: number}} */ 72 /** @typedef {{showMode: string, size: number}} */
73 WebInspector.SplitWidget.SettingForOrientation; 73 WebInspector.SplitWidget.SettingForOrientation;
74 74
75 WebInspector.SplitWidget.ShowMode = { 75 WebInspector.SplitWidget.ShowMode = {
76 Both: "Both", 76 Both: "Both",
77 OnlyMain: "OnlyMain", 77 OnlyMain: "OnlyMain",
78 OnlySidebar: "OnlySidebar" 78 OnlySidebar: "OnlySidebar"
79 } 79 }
80 80
81 /** @enum {symbol} */
81 WebInspector.SplitWidget.Events = { 82 WebInspector.SplitWidget.Events = {
82 SidebarSizeChanged: "SidebarSizeChanged", 83 SidebarSizeChanged: Symbol("SidebarSizeChanged"),
83 ShowModeChanged: "ShowModeChanged" 84 ShowModeChanged: Symbol("ShowModeChanged")
84 } 85 }
85 86
86 WebInspector.SplitWidget.MinPadding = 20; 87 WebInspector.SplitWidget.MinPadding = 20;
87 88
88 WebInspector.SplitWidget.prototype = { 89 WebInspector.SplitWidget.prototype = {
89 /** 90 /**
90 * @return {boolean} 91 * @return {boolean}
91 */ 92 */
92 isVertical: function() 93 isVertical: function()
93 { 94 {
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 this._showHideSidebarButton.classList.toggle("toggled-hide", !sidebarHid den); 918 this._showHideSidebarButton.classList.toggle("toggled-hide", !sidebarHid den);
918 this._showHideSidebarButton.classList.toggle("top-sidebar-show-hide-butt on", !this.isVertical() && !this.isSidebarSecond()); 919 this._showHideSidebarButton.classList.toggle("top-sidebar-show-hide-butt on", !this.isVertical() && !this.isSidebarSecond());
919 this._showHideSidebarButton.classList.toggle("right-sidebar-show-hide-bu tton", this.isVertical() && this.isSidebarSecond()); 920 this._showHideSidebarButton.classList.toggle("right-sidebar-show-hide-bu tton", this.isVertical() && this.isSidebarSecond());
920 this._showHideSidebarButton.classList.toggle("bottom-sidebar-show-hide-b utton", !this.isVertical() && this.isSidebarSecond()); 921 this._showHideSidebarButton.classList.toggle("bottom-sidebar-show-hide-b utton", !this.isVertical() && this.isSidebarSecond());
921 this._showHideSidebarButton.classList.toggle("left-sidebar-show-hide-but ton", this.isVertical() && !this.isSidebarSecond()); 922 this._showHideSidebarButton.classList.toggle("left-sidebar-show-hide-but ton", this.isVertical() && !this.isSidebarSecond());
922 this._showHideSidebarButton.title = sidebarHidden ? WebInspector.UIStrin g("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hide %s" , this._showHideSidebarButtonTitle); 923 this._showHideSidebarButton.title = sidebarHidden ? WebInspector.UIStrin g("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hide %s" , this._showHideSidebarButtonTitle);
923 }, 924 },
924 925
925 __proto__: WebInspector.Widget.prototype 926 __proto__: WebInspector.Widget.prototype
926 } 927 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698