Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {!WebInspector.TimelineModel} model 8 * @param {!WebInspector.TimelineModel} model
9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters 9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters
10 */ 10 */
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 var columns = [ 838 var columns = [
839 {id: "total", title: WebInspector.UIString("Total Time"), fixedWidth: tr ue, width: "110px"}, 839 {id: "total", title: WebInspector.UIString("Total Time"), fixedWidth: tr ue, width: "110px"},
840 {id: "activity", title: WebInspector.UIString("Activity")} 840 {id: "activity", title: WebInspector.UIString("Activity")}
841 ]; 841 ];
842 this._dataGrid = new WebInspector.ViewportDataGrid(columns); 842 this._dataGrid = new WebInspector.ViewportDataGrid(columns);
843 this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last); 843 this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last);
844 this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, t his._onSelectionChanged, this); 844 this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, t his._onSelectionChanged, this);
845 this._dataGrid.asWidget().show(this.element); 845 this._dataGrid.asWidget().show(this.element);
846 } 846 }
847 847
848 /** 848 /** @enum {symbol} */
849 * @enum {symbol}
850 */
851 WebInspector.TimelineStackView.Events = { 849 WebInspector.TimelineStackView.Events = {
852 SelectionChanged: Symbol("SelectionChanged") 850 SelectionChanged: Symbol("SelectionChanged")
853 } 851 }
854 852
855 WebInspector.TimelineStackView.prototype = { 853 WebInspector.TimelineStackView.prototype = {
856 /** 854 /**
857 * @param {!Array<!WebInspector.TimelineProfileTree.Node>} stack 855 * @param {!Array<!WebInspector.TimelineProfileTree.Node>} stack
858 * @param {!WebInspector.TimelineProfileTree.Node} selectedNode 856 * @param {!WebInspector.TimelineProfileTree.Node} selectedNode
859 */ 857 */
860 setStack: function(stack, selectedNode) 858 setStack: function(stack, selectedNode)
(...skipping 20 matching lines...) Expand all
881 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode; 879 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode;
882 }, 880 },
883 881
884 _onSelectionChanged: function() 882 _onSelectionChanged: function()
885 { 883 {
886 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged); 884 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged);
887 }, 885 },
888 886
889 __proto__: WebInspector.VBox.prototype 887 __proto__: WebInspector.VBox.prototype
890 } 888 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698