Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1866 matching lines...) Expand 10 before | Expand all | Expand 10 after
1877 WebInspector.Object.call(this); 1877 WebInspector.Object.call(this);
1878 1878
1879 this._categoryFilter = new WebInspector.TimelineCategoryFilter(); 1879 this._categoryFilter = new WebInspector.TimelineCategoryFilter();
1880 this._durationFilter = new WebInspector.TimelineIsLongFilter(); 1880 this._durationFilter = new WebInspector.TimelineIsLongFilter();
1881 this._textFilter = new WebInspector.TimelineTextFilter(); 1881 this._textFilter = new WebInspector.TimelineTextFilter();
1882 this._filters = [this._categoryFilter, this._durationFilter, this._textFilte r]; 1882 this._filters = [this._categoryFilter, this._durationFilter, this._textFilte r];
1883 1883
1884 this._createFilterBar(); 1884 this._createFilterBar();
1885 } 1885 }
1886 1886
1887 /** @enum {symbol} */
1887 WebInspector.TimelineFilters.Events = { 1888 WebInspector.TimelineFilters.Events = {
1888 FilterChanged: Symbol("FilterChanged") 1889 FilterChanged: Symbol("FilterChanged")
1889 }; 1890 };
1890 1891
1891 WebInspector.TimelineFilters._durationFilterPresetsMs = [0, 1, 15]; 1892 WebInspector.TimelineFilters._durationFilterPresetsMs = [0, 1, 15];
1892 1893
1893 WebInspector.TimelineFilters.prototype = { 1894 WebInspector.TimelineFilters.prototype = {
1894 /** 1895 /**
1895 * @return {!Array<!WebInspector.TimelineModel.Filter>} 1896 * @return {!Array<!WebInspector.TimelineModel.Filter>}
1896 */ 1897 */
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
2119 _onKeyDown: function(event) 2120 _onKeyDown: function(event)
2120 { 2121 {
2121 if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code) { 2122 if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code) {
2122 event.preventDefault(); 2123 event.preventDefault();
2123 this._apply(); 2124 this._apply();
2124 } 2125 }
2125 }, 2126 },
2126 2127
2127 __proto__: WebInspector.HBox.prototype 2128 __proto__: WebInspector.HBox.prototype
2128 } 2129 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698