Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/PaintProfilerView.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 this._selectionWindow.addEventListener(WebInspector.OverviewGrid.Events.Wind owChanged, this._onWindowChanged, this); 52 this._selectionWindow.addEventListener(WebInspector.OverviewGrid.Events.Wind owChanged, this._onWindowChanged, this);
53 53
54 this._innerBarWidth = 4 * window.devicePixelRatio; 54 this._innerBarWidth = 4 * window.devicePixelRatio;
55 this._minBarHeight = window.devicePixelRatio; 55 this._minBarHeight = window.devicePixelRatio;
56 this._barPaddingWidth = 2 * window.devicePixelRatio; 56 this._barPaddingWidth = 2 * window.devicePixelRatio;
57 this._outerBarWidth = this._innerBarWidth + this._barPaddingWidth; 57 this._outerBarWidth = this._innerBarWidth + this._barPaddingWidth;
58 58
59 this._reset(); 59 this._reset();
60 } 60 }
61 61
62 /** @enum {symbol} */
62 WebInspector.PaintProfilerView.Events = { 63 WebInspector.PaintProfilerView.Events = {
63 WindowChanged: "WindowChanged" 64 WindowChanged: Symbol("WindowChanged")
64 }; 65 };
65 66
66 WebInspector.PaintProfilerView.prototype = { 67 WebInspector.PaintProfilerView.prototype = {
67 onResize: function() 68 onResize: function()
68 { 69 {
69 this._update(); 70 this._update();
70 }, 71 },
71 72
72 /** 73 /**
73 * @param {?WebInspector.PaintProfilerSnapshot} snapshot 74 * @param {?WebInspector.PaintProfilerSnapshot} snapshot
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 var method = logItem.method.toTitleCase(); 519 var method = logItem.method.toTitleCase();
519 520
520 var logItemCategories = WebInspector.PaintProfilerView._initLogItemCategorie s(); 521 var logItemCategories = WebInspector.PaintProfilerView._initLogItemCategorie s();
521 var result = logItemCategories[method]; 522 var result = logItemCategories[method];
522 if (!result) { 523 if (!result) {
523 result = WebInspector.PaintProfilerView.categories()["misc"]; 524 result = WebInspector.PaintProfilerView.categories()["misc"];
524 logItemCategories[method] = result; 525 logItemCategories[method] = result;
525 } 526 }
526 return result; 527 return result;
527 } 528 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698