Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/Layers3DView.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 * @enum {string} 79 * @enum {string}
80 */ 80 */
81 WebInspector.Layers3DView.OutlineType = { 81 WebInspector.Layers3DView.OutlineType = {
82 Hovered: "hovered", 82 Hovered: "hovered",
83 Selected: "selected" 83 Selected: "selected"
84 } 84 }
85 85
86 /** 86 /**
87 * @enum {string} 87 * @enum {string}
88 */ 88 */
89 /** @enum {symbol} */
89 WebInspector.Layers3DView.Events = { 90 WebInspector.Layers3DView.Events = {
90 LayerSnapshotRequested: "LayerSnapshotRequested", 91 LayerSnapshotRequested: Symbol("LayerSnapshotRequested"),
91 PaintProfilerRequested: "PaintProfilerRequested", 92 PaintProfilerRequested: Symbol("PaintProfilerRequested")
92 } 93 }
93 94
94 /** 95 /**
95 * @enum {number} 96 * @enum {number}
96 */ 97 */
97 WebInspector.Layers3DView.ChromeTexture = { 98 WebInspector.Layers3DView.ChromeTexture = {
98 Left: 0, 99 Left: 0,
99 Middle: 1, 100 Middle: 1,
100 Right: 2 101 Right: 2
101 } 102 }
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 /** 807 /**
807 * @constructor 808 * @constructor
808 * @extends {WebInspector.Object} 809 * @extends {WebInspector.Object}
809 */ 810 */
810 WebInspector.LayerTextureManager = function() 811 WebInspector.LayerTextureManager = function()
811 { 812 {
812 WebInspector.Object.call(this); 813 WebInspector.Object.call(this);
813 this.reset(); 814 this.reset();
814 } 815 }
815 816
817 /** @enum {symbol} */
816 WebInspector.LayerTextureManager.Events = { 818 WebInspector.LayerTextureManager.Events = {
817 TextureUpdated: "TextureUpated" 819 TextureUpdated: Symbol("TextureUpated")
818 } 820 }
819 821
820 WebInspector.LayerTextureManager.prototype = { 822 WebInspector.LayerTextureManager.prototype = {
821 reset: function() 823 reset: function()
822 { 824 {
823 /** @type {!Object.<string, !Array.<!WebInspector.LayerTextureManager.Ti le>>} */ 825 /** @type {!Object.<string, !Array.<!WebInspector.LayerTextureManager.Ti le>>} */
824 this._tilesByLayerId = {}; 826 this._tilesByLayerId = {};
825 this._scale = 0; 827 this._scale = 0;
826 }, 828 },
827 829
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 */ 1091 */
1090 WebInspector.LayerTextureManager.Tile = function(snapshot, rect, traceEvent) 1092 WebInspector.LayerTextureManager.Tile = function(snapshot, rect, traceEvent)
1091 { 1093 {
1092 this.snapshot = snapshot; 1094 this.snapshot = snapshot;
1093 this.rect = rect; 1095 this.rect = rect;
1094 this.traceEvent = traceEvent; 1096 this.traceEvent = traceEvent;
1095 this.scale = 0; 1097 this.scale = 0;
1096 /** @type {?WebGLTexture} */ 1098 /** @type {?WebGLTexture} */
1097 this.texture = null; 1099 this.texture = null;
1098 } 1100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698