Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 this.element.classList.add("layer-details-view"); 40 this.element.classList.add("layer-details-view");
41 this._layerViewHost = layerViewHost; 41 this._layerViewHost = layerViewHost;
42 this._layerViewHost.registerView(this); 42 this._layerViewHost.registerView(this);
43 this._emptyWidget = new WebInspector.EmptyWidget(WebInspector.UIString("Sele ct a layer to see its details")); 43 this._emptyWidget = new WebInspector.EmptyWidget(WebInspector.UIString("Sele ct a layer to see its details"));
44 this._buildContent(); 44 this._buildContent();
45 } 45 }
46 46
47 /** 47 /**
48 * @enum {string} 48 * @enum {string}
49 */ 49 */
50 /** @enum {symbol} */
50 WebInspector.LayerDetailsView.Events = { 51 WebInspector.LayerDetailsView.Events = {
51 PaintProfilerRequested: "PaintProfilerRequested" 52 PaintProfilerRequested: Symbol("PaintProfilerRequested")
52 } 53 }
53 54
54 /** 55 /**
55 * @type {!Object.<string, string>} 56 * @type {!Object.<string, string>}
56 */ 57 */
57 WebInspector.LayerDetailsView.CompositingReasonDetail = { 58 WebInspector.LayerDetailsView.CompositingReasonDetail = {
58 "transform3D": WebInspector.UIString("Composition due to association with an element with a CSS 3D transform."), 59 "transform3D": WebInspector.UIString("Composition due to association with an element with a CSS 3D transform."),
59 "video": WebInspector.UIString("Composition due to association with a <video > element."), 60 "video": WebInspector.UIString("Composition due to association with a <video > element."),
60 "canvas": WebInspector.UIString("Composition due to the element being a <can vas> element."), 61 "canvas": WebInspector.UIString("Composition due to the element being a <can vas> element."),
61 "plugin": WebInspector.UIString("Composition due to association with a plugi n."), 62 "plugin": WebInspector.UIString("Composition due to association with a plugi n."),
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 var text = WebInspector.LayerDetailsView.CompositingReasonDetail[com positingReasons[i]] || compositingReasons[i]; 217 var text = WebInspector.LayerDetailsView.CompositingReasonDetail[com positingReasons[i]] || compositingReasons[i];
217 // If the text is more than one word but does not terminate with per iod, add the period. 218 // If the text is more than one word but does not terminate with per iod, add the period.
218 if (/\s.*[^.]$/.test(text)) 219 if (/\s.*[^.]$/.test(text))
219 text += "."; 220 text += ".";
220 list.createChild("li").textContent = text; 221 list.createChild("li").textContent = text;
221 } 222 }
222 }, 223 },
223 224
224 __proto__: WebInspector.Widget.prototype 225 __proto__: WebInspector.Widget.prototype
225 } 226 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698