Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) IBM Corp. 2009 All rights reserved. 2 * Copyright (C) IBM Corp. 2009 All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 this._element = createElementWithClass("div", "watch-expression monospace"); 243 this._element = createElementWithClass("div", "watch-expression monospace");
244 this._editing = false; 244 this._editing = false;
245 this._linkifier = linkifier; 245 this._linkifier = linkifier;
246 246
247 this._createWatchExpression(null); 247 this._createWatchExpression(null);
248 this.update(); 248 this.update();
249 } 249 }
250 250
251 WebInspector.WatchExpression._watchObjectGroupId = "watch-group"; 251 WebInspector.WatchExpression._watchObjectGroupId = "watch-group";
252 252
253 /** @enum {symbol} */
253 WebInspector.WatchExpression.Events = { 254 WebInspector.WatchExpression.Events = {
254 ExpressionUpdated: "ExpressionUpdated" 255 ExpressionUpdated: Symbol("ExpressionUpdated")
255 } 256 }
256 257
257 WebInspector.WatchExpression.prototype = { 258 WebInspector.WatchExpression.prototype = {
258 259
259 /** 260 /**
260 * @return {!Element} 261 * @return {!Element}
261 */ 262 */
262 element: function() 263 element: function()
263 { 264 {
264 return this._element; 265 return this._element;
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 contextMenu.appendApplicableItems(this._result); 450 contextMenu.appendApplicableItems(this._result);
450 }, 451 },
451 452
452 _copyValueButtonClicked: function() 453 _copyValueButtonClicked: function()
453 { 454 {
454 InspectorFrontendHost.copyText(this._valueElement.textContent); 455 InspectorFrontendHost.copyText(this._valueElement.textContent);
455 }, 456 },
456 457
457 __proto__: WebInspector.Object.prototype 458 __proto__: WebInspector.Object.prototype
458 } 459 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698