Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 this._tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabClos ed, this._tabClosed, this); 63 this._tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabClos ed, this._tabClosed, this);
64 this._tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabSele cted, this._tabSelected, this); 64 this._tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabSele cted, this._tabSelected, this);
65 65
66 this._tabIds = new Map(); 66 this._tabIds = new Map();
67 this._files = {}; 67 this._files = {};
68 68
69 this._previouslyViewedFilesSetting = setting; 69 this._previouslyViewedFilesSetting = setting;
70 this._history = WebInspector.TabbedEditorContainer.History.fromObject(this._ previouslyViewedFilesSetting.get()); 70 this._history = WebInspector.TabbedEditorContainer.History.fromObject(this._ previouslyViewedFilesSetting.get());
71 } 71 }
72 72
73 /** @enum {symbol} */
73 WebInspector.TabbedEditorContainer.Events = { 74 WebInspector.TabbedEditorContainer.Events = {
74 EditorSelected: "EditorSelected", 75 EditorSelected: Symbol("EditorSelected"),
75 EditorClosed: "EditorClosed" 76 EditorClosed: Symbol("EditorClosed")
76 } 77 }
77 78
78 WebInspector.TabbedEditorContainer._tabId = 0; 79 WebInspector.TabbedEditorContainer._tabId = 0;
79 80
80 WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount = 30; 81 WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount = 30;
81 82
82 WebInspector.TabbedEditorContainer.prototype = { 83 WebInspector.TabbedEditorContainer.prototype = {
83 /** 84 /**
84 * @return {!WebInspector.Widget} 85 * @return {!WebInspector.Widget}
85 */ 86 */
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 /** 751 /**
751 * @override 752 * @override
752 * @param {string} tabId 753 * @param {string} tabId
753 * @param {!WebInspector.ContextMenu} contextMenu 754 * @param {!WebInspector.ContextMenu} contextMenu
754 */ 755 */
755 onContextMenu: function(tabId, contextMenu) 756 onContextMenu: function(tabId, contextMenu)
756 { 757 {
757 this._editorContainer._onContextMenu(tabId, contextMenu); 758 this._editorContainer._onContextMenu(tabId, contextMenu);
758 } 759 }
759 } 760 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698