Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 /** @type {!Map<number, !WebInspector.ExecutionContext>} */ 44 /** @type {!Map<number, !WebInspector.ExecutionContext>} */
45 this._executionContextById = new Map(); 45 this._executionContextById = new Map();
46 this._executionContextComparator = WebInspector.ExecutionContext.comparator; 46 this._executionContextComparator = WebInspector.ExecutionContext.comparator;
47 47
48 if (WebInspector.moduleSetting("customFormatters").get()) 48 if (WebInspector.moduleSetting("customFormatters").get())
49 this._agent.setCustomObjectFormatterEnabled(true); 49 this._agent.setCustomObjectFormatterEnabled(true);
50 50
51 WebInspector.moduleSetting("customFormatters").addChangeListener(this._custo mFormattersStateChanged.bind(this)); 51 WebInspector.moduleSetting("customFormatters").addChangeListener(this._custo mFormattersStateChanged.bind(this));
52 } 52 }
53 53
54 /** @enum {symbol} */
54 WebInspector.RuntimeModel.Events = { 55 WebInspector.RuntimeModel.Events = {
55 ExecutionContextCreated: "ExecutionContextCreated", 56 ExecutionContextCreated: ("ExecutionContextCreated"),
56 ExecutionContextDestroyed: "ExecutionContextDestroyed", 57 ExecutionContextDestroyed: ("ExecutionContextDestroyed"),
57 ExecutionContextChanged: "ExecutionContextChanged", 58 ExecutionContextChanged: ("ExecutionContextChanged"),
58 ExecutionContextOrderChanged: "ExecutionContextOrderChanged" 59 ExecutionContextOrderChanged: ("ExecutionContextOrderChanged")
59 } 60 }
60 61
61 WebInspector.RuntimeModel._privateScript = "private script"; 62 WebInspector.RuntimeModel._privateScript = "private script";
62 63
63 WebInspector.RuntimeModel.prototype = { 64 WebInspector.RuntimeModel.prototype = {
64 65
65 /** 66 /**
66 * @return {!Array.<!WebInspector.ExecutionContext>} 67 * @return {!Array.<!WebInspector.ExecutionContext>}
67 */ 68 */
68 executionContexts: function() 69 executionContexts: function()
(...skipping 942 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 /** 1012 /**
1012 * @return {boolean} 1013 * @return {boolean}
1013 */ 1014 */
1014 isNormalListenerType: function() 1015 isNormalListenerType: function()
1015 { 1016 {
1016 return this._listenerType === "normal"; 1017 return this._listenerType === "normal";
1017 }, 1018 },
1018 1019
1019 __proto__: WebInspector.SDKObject.prototype 1020 __proto__: WebInspector.SDKObject.prototype
1020 } 1021 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698