Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 target.registerPageDispatcher(new WebInspector.PageDispatcher(this)); 54 target.registerPageDispatcher(new WebInspector.PageDispatcher(this));
55 55
56 this._pendingReloadOptions = null; 56 this._pendingReloadOptions = null;
57 this._reloadSuspensionCount = 0; 57 this._reloadSuspensionCount = 0;
58 this._fireExecutionContextOrderChanged = target.runtimeModel.fireExecutionCo ntextOrderChanged.bind(target.runtimeModel); 58 this._fireExecutionContextOrderChanged = target.runtimeModel.fireExecutionCo ntextOrderChanged.bind(target.runtimeModel);
59 59
60 target.runtimeModel.setExecutionContextComparator(this._executionContextComp arator.bind(this)); 60 target.runtimeModel.setExecutionContextComparator(this._executionContextComp arator.bind(this));
61 } 61 }
62 62
63 /** @enum {symbol} */
63 WebInspector.ResourceTreeModel.EventTypes = { 64 WebInspector.ResourceTreeModel.EventTypes = {
64 FrameAdded: "FrameAdded", 65 FrameAdded: Symbol("FrameAdded"),
65 FrameNavigated: "FrameNavigated", 66 FrameNavigated: Symbol("FrameNavigated"),
66 FrameDetached: "FrameDetached", 67 FrameDetached: Symbol("FrameDetached"),
67 FrameResized: "FrameResized", 68 FrameResized: Symbol("FrameResized"),
68 FrameWillNavigate: "FrameWillNavigate", 69 FrameWillNavigate: Symbol("FrameWillNavigate"),
69 MainFrameNavigated: "MainFrameNavigated", 70 MainFrameNavigated: WebInspector.TargetManager.Events.MainFrameNavigated,
70 ResourceAdded: "ResourceAdded", 71 ResourceAdded: Symbol("ResourceAdded"),
71 WillLoadCachedResources: "WillLoadCachedResources", 72 WillLoadCachedResources: Symbol("WillLoadCachedResources"),
72 CachedResourcesLoaded: "CachedResourcesLoaded", 73 CachedResourcesLoaded: Symbol("CachedResourcesLoaded"),
73 DOMContentLoaded: "DOMContentLoaded", 74 DOMContentLoaded: Symbol("DOMContentLoaded"),
74 Load: "Load", 75 Load: WebInspector.TargetManager.Events.Load,
75 PageReloadRequested: "PageReloadRequested", 76 PageReloadRequested: WebInspector.TargetManager.Events.PageReloadRequested,
76 WillReloadPage: "WillReloadPage", 77 WillReloadPage: WebInspector.TargetManager.Events.WillReloadPage,
77 ScreencastFrame: "ScreencastFrame", 78 ScreencastFrame: Symbol("ScreencastFrame"),
78 ScreencastVisibilityChanged: "ScreencastVisibilityChanged", 79 ScreencastVisibilityChanged: Symbol("ScreencastVisibilityChanged"),
79 ColorPicked: "ColorPicked", 80 ColorPicked: Symbol("ColorPicked"),
80 InterstitialShown: "InterstitialShown", 81 InterstitialShown: Symbol("InterstitialShown"),
81 InterstitialHidden: "InterstitialHidden" 82 InterstitialHidden: Symbol("InterstitialHidden")
82 } 83 }
83 84
84 /** 85 /**
85 * @param {!WebInspector.Target} target 86 * @param {!WebInspector.Target} target
86 * @return {?WebInspector.ResourceTreeModel} 87 * @return {?WebInspector.ResourceTreeModel}
87 */ 88 */
88 WebInspector.ResourceTreeModel.fromTarget = function(target) 89 WebInspector.ResourceTreeModel.fromTarget = function(target)
89 { 90 {
90 return /** @type {?WebInspector.ResourceTreeModel} */ (target.model(WebInspe ctor.ResourceTreeModel)); 91 return /** @type {?WebInspector.ResourceTreeModel} */ (target.model(WebInspe ctor.ResourceTreeModel));
91 } 92 }
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 935
935 /** 936 /**
936 * @override 937 * @override
937 */ 938 */
938 navigationRequested: function() 939 navigationRequested: function()
939 { 940 {
940 // Frontend is not interested in when navigations are requested. 941 // Frontend is not interested in when navigations are requested.
941 } 942 }
942 943
943 } 944 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698