Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 /** @type {!SecurityAgent.SecurityState} */ 88 /** @type {!SecurityAgent.SecurityState} */
89 this._securityState = SecurityAgent.SecurityState.Unknown; 89 this._securityState = SecurityAgent.SecurityState.Unknown;
90 /** @type {?NetworkAgent.SecurityDetails} */ 90 /** @type {?NetworkAgent.SecurityDetails} */
91 this._securityDetails = null; 91 this._securityDetails = null;
92 92
93 /** @type {string} */ 93 /** @type {string} */
94 this.connectionId = "0"; 94 this.connectionId = "0";
95 } 95 }
96 96
97 /** @enum {symbol} */
97 WebInspector.NetworkRequest.Events = { 98 WebInspector.NetworkRequest.Events = {
98 FinishedLoading: "FinishedLoading", 99 FinishedLoading: Symbol("FinishedLoading"),
99 TimingChanged: "TimingChanged", 100 TimingChanged: Symbol("TimingChanged"),
100 RemoteAddressChanged: "RemoteAddressChanged", 101 RemoteAddressChanged: Symbol("RemoteAddressChanged"),
101 RequestHeadersChanged: "RequestHeadersChanged", 102 RequestHeadersChanged: Symbol("RequestHeadersChanged"),
102 ResponseHeadersChanged: "ResponseHeadersChanged", 103 ResponseHeadersChanged: Symbol("ResponseHeadersChanged"),
103 WebsocketFrameAdded: "WebsocketFrameAdded", 104 WebsocketFrameAdded: Symbol("WebsocketFrameAdded"),
104 EventSourceMessageAdded: "EventSourceMessageAdded", 105 EventSourceMessageAdded: Symbol("EventSourceMessageAdded")
105 } 106 }
106 107
107 /** @enum {string} */ 108 /** @enum {string} */
108 WebInspector.NetworkRequest.InitiatorType = { 109 WebInspector.NetworkRequest.InitiatorType = {
109 Other: "other", 110 Other: "other",
110 Parser: "parser", 111 Parser: "parser",
111 Redirect: "redirect", 112 Redirect: "redirect",
112 Script: "script" 113 Script: "script"
113 } 114 }
114 115
(...skipping 1125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 /** 1241 /**
1241 * @return {!WebInspector.NetworkManager} 1242 * @return {!WebInspector.NetworkManager}
1242 */ 1243 */
1243 networkManager: function() 1244 networkManager: function()
1244 { 1245 {
1245 return this._networkManager; 1246 return this._networkManager;
1246 }, 1247 },
1247 1248
1248 __proto__: WebInspector.SDKObject.prototype 1249 __proto__: WebInspector.SDKObject.prototype
1249 } 1250 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698