Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 this._blockedSetting.set([]); 726 this._blockedSetting.set([]);
727 this._updateBlockedURLs(); 727 this._updateBlockedURLs();
728 728
729 this._userAgentOverride = ""; 729 this._userAgentOverride = "";
730 /** @type {!Set<!Protocol.NetworkAgent>} */ 730 /** @type {!Set<!Protocol.NetworkAgent>} */
731 this._agents = new Set(); 731 this._agents = new Set();
732 /** @type {!WebInspector.NetworkManager.Conditions} */ 732 /** @type {!WebInspector.NetworkManager.Conditions} */
733 this._networkConditions = WebInspector.NetworkManager.NoThrottlingConditions ; 733 this._networkConditions = WebInspector.NetworkManager.NoThrottlingConditions ;
734 } 734 }
735 735
736 /** @enum {symbol} */
736 WebInspector.MultitargetNetworkManager.Events = { 737 WebInspector.MultitargetNetworkManager.Events = {
737 ConditionsChanged: "ConditionsChanged", 738 ConditionsChanged: Symbol("ConditionsChanged"),
738 UserAgentChanged: "UserAgentChanged" 739 UserAgentChanged: Symbol("UserAgentChanged")
739 } 740 }
740 741
741 WebInspector.MultitargetNetworkManager.prototype = { 742 WebInspector.MultitargetNetworkManager.prototype = {
742 /** 743 /**
743 * @override 744 * @override
744 * @param {!WebInspector.Target} target 745 * @param {!WebInspector.Target} target
745 */ 746 */
746 targetAdded: function(target) 747 targetAdded: function(target)
747 { 748 {
748 var networkAgent = target.networkAgent(); 749 var networkAgent = target.networkAgent();
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
943 WebInspector.ResourceLoader.load(url, headers, callback); 944 WebInspector.ResourceLoader.load(url, headers, callback);
944 }, 945 },
945 946
946 __proto__: WebInspector.Object.prototype 947 __proto__: WebInspector.Object.prototype
947 } 948 }
948 949
949 /** 950 /**
950 * @type {!WebInspector.MultitargetNetworkManager} 951 * @type {!WebInspector.MultitargetNetworkManager}
951 */ 952 */
952 WebInspector.multitargetNetworkManager; 953 WebInspector.multitargetNetworkManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698