Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 * Position is an item position in the provider. 46 * Position is an item position in the provider.
47 */ 47 */
48 this._retrievedChildrenRanges = []; 48 this._retrievedChildrenRanges = [];
49 49
50 /** 50 /**
51 * @type {?WebInspector.HeapSnapshotGridNode.ChildrenProvider} 51 * @type {?WebInspector.HeapSnapshotGridNode.ChildrenProvider}
52 */ 52 */
53 this._providerObject = null; 53 this._providerObject = null;
54 } 54 }
55 55
56 /** @enum {symbol} */
56 WebInspector.HeapSnapshotGridNode.Events = { 57 WebInspector.HeapSnapshotGridNode.Events = {
57 PopulateComplete: "PopulateComplete" 58 PopulateComplete: Symbol("PopulateComplete")
58 } 59 }
59 60
60 /** 61 /**
61 * @param {!Array.<string>} fieldNames 62 * @param {!Array.<string>} fieldNames
62 * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig} 63 * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
63 */ 64 */
64 WebInspector.HeapSnapshotGridNode.createComparator = function(fieldNames) 65 WebInspector.HeapSnapshotGridNode.createComparator = function(fieldNames)
65 { 66 {
66 return /** @type {!WebInspector.HeapSnapshotCommon.ComparatorConfig} */ ({fi eldName1: fieldNames[0], ascending1: fieldNames[1], fieldName2: fieldNames[2], a scending2: fieldNames[3]}); 67 return /** @type {!WebInspector.HeapSnapshotCommon.ComparatorConfig} */ ({fi eldName1: fieldNames[0], ascending1: fieldNames[1], fieldName2: fieldNames[2], a scending2: fieldNames[3]});
67 } 68 }
(...skipping 1454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1522 /** 1523 /**
1523 * @return {number} 1524 * @return {number}
1524 */ 1525 */
1525 allocationNodeId: function() 1526 allocationNodeId: function()
1526 { 1527 {
1527 return this._allocationNode.id; 1528 return this._allocationNode.id;
1528 }, 1529 },
1529 1530
1530 __proto__: WebInspector.HeapSnapshotGridNode.prototype 1531 __proto__: WebInspector.HeapSnapshotGridNode.prototype
1531 } 1532 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698